Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1164313002: Add CSS snap points properties to histogram (Closed)

Created:
5 years, 6 months ago by majidvp
Modified:
5 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CSS snap points properties to histogram These properties have been added here: https://crrev.com/1148873005/ BUG=311234 Committed: https://crrev.com/b73a6facf0908083cfb601f93bb9a8f26c81e8e0 Cr-Commit-Position: refs/heads/master@{#333563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
majidvp
+asvitkine for OWNER review. I am following the process described here: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/frame/UseCounter.cpp&sq=package:chromium&type=cs&l=536&rcl=1433777749 FYI, the additional ...
5 years, 6 months ago (2015-06-08 20:58:24 UTC) #1
Alexei Svitkine (slow)
Can you point to the corresponding CL in blink?
5 years, 6 months ago (2015-06-08 22:24:47 UTC) #3
majidvp
It is here: https://codereview.chromium.org/1148873005/ On Mon, Jun 8, 2015, 6:24 PM <asvitkine@chromium.org> wrote: > Can ...
5 years, 6 months ago (2015-06-08 23:20:22 UTC) #4
Alexei Svitkine (slow)
lgtm
5 years, 6 months ago (2015-06-08 23:48:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164313002/1
5 years, 6 months ago (2015-06-09 18:20:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 20:31:03 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 20:31:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b73a6facf0908083cfb601f93bb9a8f26c81e8e0
Cr-Commit-Position: refs/heads/master@{#333563}

Powered by Google App Engine
This is Rietveld 408576698