Issue 1164303002: Introduce sky.Sky.zero

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1164303002: Introduce sky.Sky.zero (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Introduce sky.Sky.zero And deploy it in a few places. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/fad1c3b3a0ff25975352903b49075e65ae66204f

Patch Set 2 : less sky.Foo #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -25 lines)			Patch
M	sky/engine/core/painting/Size.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/examples/raw/sector_layout.dart	View	1	10 chunks	+21 lines, -21 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/box.dart	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hixie

https://codereview.chromium.org/1164303002/diff/1/sky/examples/raw/sector_layout.dart File sky/examples/raw/sector_layout.dart (right): https://codereview.chromium.org/1164303002/diff/1/sky/examples/raw/sector_layout.dart#newcode404 sky/examples/raw/sector_layout.dart:404: return constraints.constrain(sky.Size.zero); You should be able to remove the ...

5 years, 6 months ago (2015-06-08 17:01:53 UTC) #2

abarth-chromium

5 years, 6 months ago (2015-06-08 17:09:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
fad1c3b3a0ff25975352903b49075e65ae66204f (presubmit successful).

Expand Messages | Collapse Messages

Issue 1164303002: Introduce sky.Sky.zero (Closed)

Description

Patch Set 1 #

Patch Set 2 : less sky.Foo #

Messages