Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: Source/core/inspector/WorkerInspectorController.cpp

Issue 1164263002: DevTools: disable interrupts when dispatching inspector commands (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Removed invalid assert Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/InspectorTaskRunner.cpp ('k') | Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 { 188 {
189 ASSERT(!m_frontend); 189 ASSERT(!m_frontend);
190 connectFrontend(); 190 connectFrontend();
191 m_state->loadFromCookie(inspectorCookie); 191 m_state->loadFromCookie(inspectorCookie);
192 192
193 m_agents.restore(); 193 m_agents.restore();
194 } 194 }
195 195
196 void WorkerInspectorController::dispatchMessageFromFrontend(const String& messag e) 196 void WorkerInspectorController::dispatchMessageFromFrontend(const String& messag e)
197 { 197 {
198 m_inspectorTaskRunner->setIgnoreInterrupts(true); 198 InspectorTaskRunner::IgnoreInterruptsScope scope(m_inspectorTaskRunner.get() );
199 if (m_backendDispatcher) 199 if (m_backendDispatcher)
200 m_backendDispatcher->dispatch(message); 200 m_backendDispatcher->dispatch(message);
201 m_inspectorTaskRunner->setIgnoreInterrupts(false);
202 } 201 }
203 202
204 void WorkerInspectorController::dispose() 203 void WorkerInspectorController::dispose()
205 { 204 {
206 m_instrumentingAgents->reset(); 205 m_instrumentingAgents->reset();
207 disconnectFrontend(); 206 disconnectFrontend();
208 } 207 }
209 208
210 void WorkerInspectorController::interruptAndDispatchInspectorCommands() 209 void WorkerInspectorController::interruptAndDispatchInspectorCommands()
211 { 210 {
(...skipping 30 matching lines...) Expand all
242 visitor->trace(m_injectedScriptManager); 241 visitor->trace(m_injectedScriptManager);
243 visitor->trace(m_workerThreadDebugger); 242 visitor->trace(m_workerThreadDebugger);
244 visitor->trace(m_backendDispatcher); 243 visitor->trace(m_backendDispatcher);
245 visitor->trace(m_agents); 244 visitor->trace(m_agents);
246 visitor->trace(m_workerDebuggerAgent); 245 visitor->trace(m_workerDebuggerAgent);
247 visitor->trace(m_asyncCallTracker); 246 visitor->trace(m_asyncCallTracker);
248 visitor->trace(m_workerRuntimeAgent); 247 visitor->trace(m_workerRuntimeAgent);
249 } 248 }
250 249
251 } // namespace blink 250 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorTaskRunner.cpp ('k') | Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698