Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issue 1164263002: DevTools: disable interrupts when dispatching inspector commands (Closed)

Created:
4 years, 10 months ago by yurys
Modified:
4 years, 10 months ago
Reviewers:
sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: disable interrupts when dispatching inspector commands The behavior is now consistent between worker and main thread. The downside is that we won't be able to break in Runtime.evaluate. The latter can be addressed separately if we find this use case important. BUG=497224, 497395, 479096 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196742

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Added assert #

Patch Set 4 : Removed invalid assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M Source/core/inspector/InspectorTaskRunner.h View 1 1 chunk +9 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorTaskRunner.cpp View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
yurys
4 years, 10 months ago (2015-06-08 13:00:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164263002/20001
4 years, 10 months ago (2015-06-08 13:01:05 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164263002/40001
4 years, 10 months ago (2015-06-08 13:44:19 UTC) #6
sergeyv
lgtm
4 years, 10 months ago (2015-06-08 13:45:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164263002/40001
4 years, 10 months ago (2015-06-08 13:52:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/65503)
4 years, 10 months ago (2015-06-08 15:15:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164263002/60001
4 years, 10 months ago (2015-06-08 17:13:14 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65697)
4 years, 10 months ago (2015-06-08 19:34:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164263002/60001
4 years, 10 months ago (2015-06-09 05:48:06 UTC) #19
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 07:25:49 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196742

Powered by Google App Engine
This is Rietveld 408576698