Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: Source/core/editing/StyledMarkupAccumulator.h

Issue 1164253002: Refactoring: Remove boolean paramters from StyledMarkupAccumulator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: tkent's review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/editing/StyledMarkupAccumulator.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2008, 2009, 2010, 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Google Inc. All rights reserved.
4 * Copyright (C) 2011 Igalia S.L. 4 * Copyright (C) 2011 Igalia S.L.
5 * Copyright (C) 2011 Motorola Mobility. All rights reserved. 5 * Copyright (C) 2011 Motorola Mobility. All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 void appendStartTag(Node&); 54 void appendStartTag(Node&);
55 void appendEndTag(const Element&); 55 void appendEndTag(const Element&);
56 56
57 // TODO(hajimehoshi): These functions are called from the serializer, but 57 // TODO(hajimehoshi): These functions are called from the serializer, but
58 // should not. 58 // should not.
59 Node* highestNodeToBeSerialized() { return m_highestNodeToBeSerialized.get() ; } 59 Node* highestNodeToBeSerialized() { return m_highestNodeToBeSerialized.get() ; }
60 void setHighestNodeToBeSerialized(Node* highestNodeToBeSerialized) { m_highe stNodeToBeSerialized = highestNodeToBeSerialized; } 60 void setHighestNodeToBeSerialized(Node* highestNodeToBeSerialized) { m_highe stNodeToBeSerialized = highestNodeToBeSerialized; }
61 void setWrappingStyle(PassRefPtrWillBeRawPtr<EditingStyle> wrappingStyle) { m_wrappingStyle = wrappingStyle; } 61 void setWrappingStyle(PassRefPtrWillBeRawPtr<EditingStyle> wrappingStyle) { m_wrappingStyle = wrappingStyle; }
62 62
63 void wrapWithNode(ContainerNode&, RangeFullySelectsNode = DoesFullySelectNod e); 63 void wrapWithNode(ContainerNode&, RangeFullySelectsNode = DoesFullySelectNod e);
64 void wrapWithStyleNode(StylePropertySet*, bool isBlock = false); 64 void wrapWithStyleNode(StylePropertySet*);
65 String takeResults(); 65 String takeResults();
66 66
67 private: 67 private:
68 void appendText(StringBuilder&, Text&); 68 void appendText(StringBuilder&, Text&);
69 69
70 String renderedText(Text&); 70 String renderedText(Text&);
71 String stringValueForRange(const Text&); 71 String stringValueForRange(const Text&);
72 72
73 bool shouldApplyWrappingStyle(const Node&) const; 73 bool shouldApplyWrappingStyle(const Node&) const;
74 74
75 bool shouldAnnotate() const; 75 bool shouldAnnotate() const;
76 76
77 void appendElement(StringBuilder&, Element&); 77 void appendElement(StringBuilder&, Element&);
78 void appendElement(StringBuilder&, Element&, bool, RangeFullySelectsNode); 78 void appendElement(StringBuilder&, Element&, bool, RangeFullySelectsNode);
79 void appendStartMarkup(StringBuilder&, Node&); 79 void appendStartMarkup(StringBuilder&, Node&);
80 void appendEndMarkup(StringBuilder&, const Element&); 80 void appendEndMarkup(StringBuilder&, const Element&);
81 void appendStyleNodeOpenTag(StringBuilder&, StylePropertySet*, bool isBlock = false);
82 81
83 MarkupFormatter m_formatter; 82 MarkupFormatter m_formatter;
84 const TextOffset m_start; 83 const TextOffset m_start;
85 const TextOffset m_end; 84 const TextOffset m_end;
86 const RefPtrWillBeMember<Document> m_document; 85 const RefPtrWillBeMember<Document> m_document;
87 const EAnnotateForInterchange m_shouldAnnotate; 86 const EAnnotateForInterchange m_shouldAnnotate;
88 const ConvertBlocksToInlines m_convertBlocksToInlines; 87 const ConvertBlocksToInlines m_convertBlocksToInlines;
89 RawPtrWillBeMember<Node> m_highestNodeToBeSerialized; 88 RawPtrWillBeMember<Node> m_highestNodeToBeSerialized;
90 RefPtrWillBeMember<EditingStyle> m_wrappingStyle; 89 RefPtrWillBeMember<EditingStyle> m_wrappingStyle;
91 StringBuilder m_result; 90 StringBuilder m_result;
92 Vector<String> m_reversedPrecedingMarkup; 91 Vector<String> m_reversedPrecedingMarkup;
93 }; 92 };
94 93
95 } // namespace blink 94 } // namespace blink
96 95
97 #endif // StyledMarkupAccumulator_h 96 #endif // StyledMarkupAccumulator_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/editing/StyledMarkupAccumulator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698