Refactoring: Remove boolean paramters from StyledMarkupAccumulator

Refactoring: Remove boolean paramters from StyledMarkupAccumulator

It seems like that StyledMarkupAccumulator::wrapWithStyleNode's boolean
parameter is always true for all the current usages. This CL removes
this parameter.

This CL also removes appendStyleNodeOpenTag, that also uses a boolean
parameter, and inline-expanded the content to the callers.

BUG=n/a
TEST=n/a; no behavior change

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196660

[hajimehoshi, 2015-06-08 07:40:34]

hajimehoshi@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[hajimehoshi, 2015-06-08 07:40:35]

PTAL

[tkent, 2015-06-08 07:49:56]

https://codereview.chromium.org/1164253002/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupAccumulator.cpp (left):

https://codereview.chromium.org/1164253002/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.cpp:202:
ASSERT(propertyMissingOrEqualToNone(style,
CSSPropertyWebkitTextDecorationsInEffect));
The assertion is removed.  Is it intentional?

https://codereview.chromium.org/1164253002/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.cpp:207: ASSERT(m_document);
Ditto.

https://codereview.chromium.org/1164253002/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupAccumulator.cpp (right):

https://codereview.chromium.org/1164253002/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.cpp:40: namespace {
Remove this namespace block.

[hajimehoshi, 2015-06-08 07:56:56]

Thank you!

https://codereview.chromium.org/1164253002/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupAccumulator.cpp (left):

https://codereview.chromium.org/1164253002/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.cpp:202:
ASSERT(propertyMissingOrEqualToNone(style,
CSSPropertyWebkitTextDecorationsInEffect));
On 2015/06/08 07:49:56, tkent wrote:
> The assertion is removed.  Is it intentional?

Oh, I forgot that. Copied.

https://codereview.chromium.org/1164253002/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.cpp:207: ASSERT(m_document);
On 2015/06/08 07:49:56, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/1164253002/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupAccumulator.cpp (right):

https://codereview.chromium.org/1164253002/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.cpp:40: namespace {
On 2015/06/08 07:49:56, tkent wrote:
> Remove this namespace block.

Done.

[tkent, 2015-06-08 08:08:15]

The CQ bit was checked by tkent@chromium.org

[tkent, 2015-06-08 08:08:15]

lgtm

[commit-bot: I haz the power, 2015-06-08 08:08:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1164253002/20001

[commit-bot: I haz the power, 2015-06-08 09:31:40]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196660