Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 116423007: Moving Text Simple/Complex Path prefix from Font.cpp to new File (Closed)

Created:
6 years, 12 months ago by h.joshi
Modified:
6 years, 11 months ago
Reviewers:
eae, eseidel
CC:
blink-reviews, jamesr, krit, jbroman, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, danakj, Rik, f(malita), jchaffraix+rendering, pdr, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Moving Text Simple/Complex Path prefix from Font.cpp to new File Moving Text/String Path emum to new file "TextPath.h", this is done inline with the comments given in "https://codereview.chromium.org/111833006/" which required breaking commit to two. BUG=330832 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164745

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixing comments given for patch #

Patch Set 3 : Fixing merge issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -71 lines) Patch
M Source/core/rendering/RenderText.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextMetricsBuilder.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/fonts/Font.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/Font.cpp View 1 2 14 chunks +28 lines, -28 lines 0 comments Download
M Source/platform/fonts/FontTest.cpp View 1 2 3 chunks +38 lines, -38 lines 0 comments Download
M Source/platform/fonts/mac/ComplexTextController.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
A Source/platform/text/TextPath.h View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M Source/platform/text/TextRun.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eae
Change itself looks good, revert OWNERS change and I'll gladly approve it. https://codereview.chromium.org/116423007/diff/1/Source/platform/OWNERS File Source/platform/OWNERS ...
6 years, 11 months ago (2014-01-03 20:51:28 UTC) #1
h.joshi
https://codereview.chromium.org/116423007/diff/1/Source/platform/OWNERS File Source/platform/OWNERS (right): https://codereview.chromium.org/116423007/diff/1/Source/platform/OWNERS#newcode10 Source/platform/OWNERS:10: h.joshi@samsung.coms On 2014/01/03 20:51:29, eae wrote: > You can't ...
6 years, 11 months ago (2014-01-04 15:25:19 UTC) #2
h.joshi
On 2014/01/04 15:25:19, h.joshi wrote: > https://codereview.chromium.org/116423007/diff/1/Source/platform/OWNERS > File Source/platform/OWNERS (right): > > https://codereview.chromium.org/116423007/diff/1/Source/platform/OWNERS#newcode10 > ...
6 years, 11 months ago (2014-01-04 20:45:33 UTC) #3
eae
LGTM
6 years, 11 months ago (2014-01-06 15:51:25 UTC) #4
hj
On 2014/01/06 15:51:25, eae wrote: > LGTM Thank you, waiting for the CLA approve confirmation ...
6 years, 11 months ago (2014-01-07 06:34:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/h.joshi@samsung.com/116423007/150001
6 years, 11 months ago (2014-01-09 04:33:10 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/rendering/RenderText.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-09 04:33:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/h.joshi@samsung.com/116423007/230001
6 years, 11 months ago (2014-01-09 05:06:32 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 07:42:55 UTC) #9
Message was sent while issue was closed.
Change committed as 164745

Powered by Google App Engine
This is Rietveld 408576698