Issue 1164213002: Changes reference to pixels to DIPs in comments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1164213002: Changes reference to pixels to DIPs in comments (Closed)

Created:
5 years, 6 months ago by varkha

Modified:
5 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, kalyank, sadrul, dcheng, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Changes reference to pixels to DIPs in comments Fixes the units as a followup to https://codereview.chromium.org/1156893008/ BUG=491502 TEST=None TBR=sky@chromium.org Committed: https://crrev.com/524c23f73517a8e8fa0311f5920ef2581b295b02 Cr-Commit-Position: refs/heads/master@{#333222}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	ash/wm/default_state.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/views/tabs/tab_drag_controller.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164213002/1

5 years, 6 months ago (2015-06-07 02:19:26 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-07 03:03:44 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/524c23f73517a8e8fa0311f5920ef2581b295b02
Cr-Commit-Position: refs/heads/master@{#333222}