[Android] Add test that asserts screen is on.

[Android] Add test that asserts screen is on.

Lots of tests fail with seemingly random failures if the screen turns off. Add an explicit test for this so it's obvious why tests are failing.

BUG=167141
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175538

[Isaac (away), 2012-12-20 21:30:42]

Do we have 100 char limit on java now?  lgtm otherwise.

[Isaac (away), 2012-12-20 21:31:39]

https://codereview.chromium.org/11642050/diff/1/content/shell/android/javates...
File
content/shell/android/javatests/src/org/chromium/content_shell/ContentShellPreconditionsTest.java
(right):

https://codereview.chromium.org/11642050/diff/1/content/shell/android/javates...
content/shell/android/javatests/src/org/chromium/content_shell/ContentShellPreconditionsTest.java:23:
ContentShellActivity activity = launchContentShellWithUrl(URL);
Why launch content shell for this test?

[Yaron, 2012-12-20 21:43:10]

Fixed to 100 chars. Also added network connectivity test

[Isaac (away), 2012-12-20 21:48:22]

I thought you were already using 100 char.  I think the limit is 80 chars
actually.

We should make sure we don't unnecessarily block tests because the phone lacks
network connectivity.  In particular, I don't think the forwarder will change
the connectivity_service state, so plenty of phones on bots might not have
network.  It seems like a good test to have in suites which depend on network.

[Yaron, 2012-12-20 22:05:48]

The limit isn't 80. We follow Android style guide for java. It's already been
discussed and the presubmit was adjusted to allow 100 cols in java files.

As for the network connectivity thing.. I just ran content shell tests with wifi
off and they all passed so you're right. I can add that to our downstream tests
which do require some amount of connectivity.

[Isaac (use chromium), 2012-12-20 23:39:32]

The other thing that might be nice is to run this test on all phones attached to
computer instead of just one.  But that's an enhancement.

[commit-bot: I haz the power, 2013-01-07 22:58:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11642050/3002

[commit-bot: I haz the power, 2013-01-08 16:46:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11642050/3002

[commit-bot: I haz the power, 2013-01-08 16:47:00]

Change committed as 175538