Issue 11642049: [Android] Fix the bug when full path to test apk is provided.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11642049: [Android] Fix the bug when full path to test apk is provided. (Closed)

Created:
8 years ago by frankf

Modified:
8 years ago

Reviewers:
craigdh, Isaac (away)

CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Fix the bug when full path to test apk is provided. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174315

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	build/android/pylib/test_options_parser.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Isaac (away)

Did this ever work? Looks like we were adding a string to a tuple before... ...

8 years ago (2012-12-20 22:03:09 UTC) #3

Nico

8 years ago (2012-12-21 01:56:06 UTC) #7

Message was sent while issue was closed.

This CL has a fairly bad CL description. While it's clear to you what "the bug"
is, it's not clear to most others. And since there's no bug in the BUG line, one
has to guess from the patch what this is meant to do. Please take the time to
write good CL descriptions.

Expand Messages | Collapse Messages