Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 11642045: Revert 138208 (Closed)

Created:
8 years ago by kerz_chromium
Modified:
8 years ago
Reviewers:
kerz_chromium
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Revert 138208 > Revert 138189 > > Merge 138095 > > > Input elements with default touch handlers don't update handler counts when changing documents > > > https://bugs.webkit.org/show_bug.cgi?id=105334 > > > > > > Reviewed by James Robinson. > > > > > > Source/WebCore: > > > > > > When an Input element with default touch event handlers changes documents, it failed to > > > update the touch event handler sets in both the old and new document. This patch fixes this > > > case. > > > > > > Test: fast/events/touch/touch-input-element-change-documents.html > > > > > > * dom/Document.h: > > > (WebCore::Document::didRemoveTouchEventTargetNode) This function makes sense when touch > > > handling is enabled, regardless of whether we're tracking the rects. > > > * dom/Document.cpp: > > > * html/HTMLInputElement.cpp: > > > (WebCore::HTMLInputElement::~HTMLInputElement): Switch from didRemoveTouchEventHandler to > > > didRemoveTouchEventTargetNode, since we don't care about counts in the destructor. > > > (WebCore::HTMLInputElement::updateType): Fixing incorrect indentation. > > > (WebCore::HTMLInputElement::didMoveToNewDocument): Adding the node to the new document and > > > removing it from the old. > > > > > > LayoutTests: > > > > > > * fast/events/touch/touch-input-element-change-documents-expected.txt: Added. > > > * fast/events/touch/touch-input-element-change-documents.html: Added. > > > > > > > TBR=leviw@chromium.org > > Review URL: https://codereview.chromium.org/11649024 > > TBR=leviw@chromium.org > Review URL: https://codereview.chromium.org/11571072 TBR=kerz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
A + LayoutTests/fast/events/touch/touch-input-element-change-documents.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/HTMLInputElement.cpp View 3 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kerz_chromium
8 years ago (2012-12-20 18:19:26 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698