base/file_path.h - Issue 11642041: Don't allow '\0' characters in FilePath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/file_path.h

Issue 11642041: Don't allow '\0' characters in FilePath. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed comments, check that FPS() works Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/file_path.h

diff --git a/base/file_path.h b/base/file_path.h

index 09e82693bb24e5974f5ab74bc480c28c6d944b20..060ded5c326156e7ba5217f5295bc5f8ecd9daae 100644

--- a/base/file_path.h

+++ b/base/file_path.h

@@ -53,6 +53,8 @@

// between char[]-based pathnames on POSIX systems and wchar_t[]-based

// pathnames on Windows.

+// Paths can't contain NULs as a precaution agaist premature truncation.

+//

// Because a FilePath object should not be instantiated at the global scope,

// instead, use a FilePath::CharType[] and initialize it with

// FILE_PATH_LITERAL. At runtime, a FilePath object can be created from the

« no previous file with comments | « no previous file | base/file_path.cc » ('j') | base/file_path.cc » ('J')