Don't allow '\0' characters in FilePath.

content/browser/download/save_package_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
@@ skipping 91 matching lines @@
 
     // Do the initialization in SetUp so contents() is initialized by
     // RenderViewHostImplTestHarness::SetUp.
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
 
     save_package_success_ = new SavePackage(contents(),
         temp_dir_.path().AppendASCII("testfile" HTML_EXTENSION),
         temp_dir_.path().AppendASCII("testfile_files"));
 
     // We need to construct a path that is *almost* kMaxFilePathLength long
-    long_file_name.resize(kMaxFilePathLength + long_file_name.length());

[aedla, 2013/01/28 11:40:15]

Looks like reserve was intended here. Because otherwise a long string of NULs is
created and the while loop won't be executed. When appended to FilePath, all
NULs are stripped and the long path becomes a short path, causing
TestUnSuccessfullyGenerateSavePackageFilename to fail.

+    long_file_name.reserve(kMaxFilePathLength + long_file_name.length());
     while (long_file_name.length() < kMaxFilePathLength)
       long_file_name += long_file_name;
     long_file_name.resize(
         kMaxFilePathLength - 9 - temp_dir_.path().value().length());
 
     save_package_fail_ = new SavePackage(contents(),
         temp_dir_.path().AppendASCII(long_file_name + HTML_EXTENSION),
         temp_dir_.path().AppendASCII(long_file_name + "_files"));
   }
 
@@ skipping 311 matching lines @@
   GURL view_source_url = URLRequestMockHTTPJob::GetMockViewSourceUrl(
                              FilePath(kTestDir).Append(file_name));
   GURL actual_url = URLRequestMockHTTPJob::GetMockUrl(
                         FilePath(kTestDir).Append(file_name));
   NavigateAndCommit(view_source_url);
   EXPECT_EQ(actual_url, GetUrlToBeSaved());
   EXPECT_EQ(view_source_url, contents()->GetURL());
 }
 
 }  // namespace content