Chromium Code Reviews| Index: build/common.gypi |
| diff --git a/build/common.gypi b/build/common.gypi |
| index 33d47b14190f447969d520af839ed8c2a392f25f..0e823254b8646fa9dbf358585a4b145cbfed099d 100644 |
| --- a/build/common.gypi |
| +++ b/build/common.gypi |
| @@ -350,19 +350,11 @@ |
| # Use of precompiled headers on Windows. |
| # |
| - # This is on by default in VS 2010, but off by default for VS |
| - # 2008 because of complications that it can cause with our |
| - # trybots etc. |
| - # |
| # This variable may be explicitly set to 1 (enabled) or 0 |
| # (disabled) in ~/.gyp/include.gypi or via the GYP command line. |
| # This setting will override the default. |
| # |
| - # Note that a setting of 1 is probably suitable for most or all |
| - # Windows developers using VS 2008, since precompiled headers |
| - # provide a build speedup of 20-25%. There are a couple of |
| - # small workarounds you may need to use when using VS 2008 (but |
| - # not 2010), see |
| + # See |
| # http://code.google.com/p/chromium/wiki/WindowsPrecompiledHeaders |
| # for details. |
| 'chromium_win_pch%': 0, |
| @@ -516,7 +508,7 @@ |
| }], |
| # Turn precompiled headers on by default for VS 2010. |
|
Jói
2012/12/20 13:04:25
May want to update this comment.
scottmg
2012/12/20 18:35:14
Done.
|
| - ['OS=="win" and MSVS_VERSION=="2010" and buildtype!="Official"', { |
| + ['OS=="win" and buildtype!="Official"', { |
| 'chromium_win_pch%': 1 |
| }], |