ash/magnifier/magnifier_constants.h - Issue 11642014: Re-introduce the partial magnifier

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/magnifier/magnifier_constants.h

Issue 11642014: Re-introduce the partial magnifier (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review fix (comment #8) Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ASH_MAGNIFIER_MAGNIFIER_CONSTANTS_H_	5 #ifndef ASH_MAGNIFIER_MAGNIFIER_CONSTANTS_H_

6 #define ASH_MAGNIFIER_MAGNIFIER_CONSTANTS_H_	6 #define ASH_MAGNIFIER_MAGNIFIER_CONSTANTS_H_

7	7

8 namespace ash {	8 namespace ash {

9	9

	10 // Note: Do not change these values; UMA and prefs depend on them.

10 enum MagnifierType {	11 enum MagnifierType {

11 MAGNIFIER_OFF,	12 MAGNIFIER_FULL = 1,

12 MAGNIFIER_FULL,	13 MAGNIFIER_PARTIAL = 2,

13 MAGNIFIER_PARTIAL,

14 };	14 };

15	15

	16 // This value must be the maximum number of MagnifierType) + 1
	Daniel Erat 2013/01/09 15:43:56 s/)// this is a bit misleading, though (it's 3, b s/)// this is a bit misleading, though (it's 3, but there are only 2 types). maybe you could rename this to kMaxMagnifierType, set it to 2, and then just do kMaxMagnifierType + 1 when recording the metric? yoshiki 2013/01/10 06:25:39 Done. Show quoted text On 2013/01/09 15:43:56, Daniel Erat wrote: > s/)// > > this is a bit misleading, though (it's 3, but there are only 2 types). maybe > you could rename this to kMaxMagnifierType, set it to 2, and then just do > kMaxMagnifierType + 1 when recording the metric? Done.
	17 const int kNumMagnifierTypes = 3;

	18

	19 const MagnifierType kDefaultMagnifierType = MAGNIFIER_FULL;

	20

16 } // namespace ash	21 } // namespace ash

17	22

18 #endif // ASH_MAGNIFIER_MAGNIFIER_CONSTANTS_H_	23 #endif // ASH_MAGNIFIER_MAGNIFIER_CONSTANTS_H_

OLD	NEW

« no previous file with comments | « no previous file | ash/shell/shell_delegate_impl.h » ('j') | chrome/browser/chromeos/accessibility/magnification_manager.cc » ('J')