Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 11642006: Generate shim headers when using system v8. (Closed)

Created:
8 years ago by Paweł Hajdan Jr.
Modified:
7 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Generate shim headers when using system v8. BUG=chromium:165264 Committed: http://code.google.com/p/v8/source/detail?r=13392

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M tools/gyp/v8.gyp View 1 2 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Paweł Hajdan Jr.
8 years ago (2012-12-19 00:49:38 UTC) #1
Jakob Kummerow
LGTM. I'll land this for you.
7 years, 11 months ago (2013-01-09 09:58:15 UTC) #2
Jakob Kummerow
Uhm, no, scratch that. This CL breaks standalone V8 compilation, because ../build/shim_headers.gypi doesn't exist. To ...
7 years, 11 months ago (2013-01-09 10:57:19 UTC) #3
Paweł Hajdan Jr.
PTAL
7 years, 11 months ago (2013-01-11 21:33:59 UTC) #4
Jakob Kummerow
Generally LGTM, but I do have a question before landing this. https://chromiumcodereview.appspot.com/11642006/diff/5001/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): ...
7 years, 11 months ago (2013-01-14 12:07:46 UTC) #5
Paweł Hajdan Jr.
Oh, thank you for catching possible issues. I've done more testing for use_system_v8=1 case, and ...
7 years, 11 months ago (2013-01-14 18:43:44 UTC) #6
Jakob Kummerow
7 years, 11 months ago (2013-01-15 12:35:05 UTC) #7
OK, I'll land patch set 3.

Powered by Google App Engine
This is Rietveld 408576698