Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: remoting/chromoting_test.gyp

Issue 1164143002: Added new driver for chromoting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed comments to be clearer and alphabetized targets. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/chromoting_test.gyp
diff --git a/remoting/chromoting_test.gyp b/remoting/chromoting_test.gyp
new file mode 100644
index 0000000000000000000000000000000000000000..61744ca16d57f938cc34ba90ffc6ace41762f5e6
--- /dev/null
+++ b/remoting/chromoting_test.gyp
@@ -0,0 +1,32 @@
+# Copyright 2015 The Chromium Authors. All rights reserved.
Sergey Ulanov 2015/06/08 18:57:37 Do we really need to add this extra .gyp file? Why
tonychun 2015/06/08 20:35:58 I completely agree. This change would optimize gyp
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+ 'includes': [
+ 'remoting_version.gypi',
+ ],
+
+ 'target_defaults': {
Sergey Ulanov 2015/06/08 18:57:37 Why do you need this?
tonychun 2015/06/08 20:35:58 I thought, by default, every .gyp file requires a
+ 'type': 'none',
+ }, # target_defaults
+ 'targets': [
+ {
+ # A chromoting version of the common test driver tool
joedow 2015/06/08 18:35:20 what is the common test driver tool?
tonychun 2015/06/08 20:35:58 It is the common lib in remoting_all.gyp. I will r
+ 'target_name': 'chromoting_test_driver',
+ 'type': '<(gtest_target_type)',
+ 'dependencies': [
+ '<(DEPTH)/remoting/remoting_test_driver_common.gyp:remoting_test_driver_common',
+ ],
+ 'defines': [
+ 'VERSION=<(version_full)',
+ ],
+ 'sources': [
+ 'test/chromoting_test_driver.cc',
+ ],
+ 'include_dirs': [
+ '../testing/gtest/include',
+ ],
+ }, # end of target 'chromoting_test_driver'
+ ], # end of targets
+}

Powered by Google App Engine
This is Rietveld 408576698