Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1164133003: Document the tracking bugs of some IDL FIXMEs and TODOs (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, fs, kouhei+svg_chromium.org, vivekg, dglazkov+blink, krit, f(malita), Inactive, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Document the tracking bugs of some IDL FIXMEs and TODOs Also remove the invalid spec bug link for ProcessingInstruction. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ProcessingInstruction.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
philipj_slow
PTAL. I threw in an unrelated change in ProcessingInstruction too.
5 years, 6 months ago (2015-06-05 22:49:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164133003/1
5 years, 6 months ago (2015-06-05 22:50:17 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-06 01:46:13 UTC) #6
Rick Byers
LGTM. Maybe briefly mention the ProcessingInstruction change in your CL description too.
5 years, 6 months ago (2015-06-06 17:23:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164133003/1
5 years, 6 months ago (2015-06-06 21:57:30 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-06 22:01:16 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196630

Powered by Google App Engine
This is Rietveld 408576698