Chromium Code Reviews| Index: tools/dom/src/_HttpRequestUtils.dart |
| diff --git a/tools/dom/src/_HttpRequestUtils.dart b/tools/dom/src/_HttpRequestUtils.dart |
| index 36a46ec94ea7424a7bff24dcacf0285a22daa328..4ef6b38c22aa4d51575c2d54bbc4e823b8d2d57d 100644 |
| --- a/tools/dom/src/_HttpRequestUtils.dart |
| +++ b/tools/dom/src/_HttpRequestUtils.dart |
| @@ -8,18 +8,26 @@ class _HttpRequestUtils { |
| // Helper for factory HttpRequest.get |
| static HttpRequest get(String url, |
| - onSuccess(HttpRequest request), |
| + onComplete(HttpRequest request), |
| bool withCredentials) { |
| final request = new HttpRequest(); |
| request.open('GET', url, true); |
| request.withCredentials = withCredentials; |
| - // Status 0 is for local XHR request. |
| request.on.readyStateChange.add((e) { |
| - if (request.readyState == HttpRequest.DONE && |
| - (request.status == 200 || request.status == 0)) { |
| - onSuccess(request); |
| + if (request.readyState == HttpRequest.DONE) { |
| + // TODO(efortuna): Previously the HttpRequest.get only called the |
|
Jacob
2013/01/04 23:55:25
gramar nit: rewrite first sentence as
previously H
|
| + // callback with the additional constraints below on the status. This |
| + // causes two problems 1) request.status = 0 for ANY local XHR request |
| + // (file found or not found) 2) the user facing function claims that the |
| + // callback is called on completion of the request, regardless of |
| + // status. Because the new event model is coming in soon, rather than |
| + // fixing the callbacks version, we just need to revisit the desired |
| + // behavior when we're using streams/futures. |
| + // Status 0 is for local XHR request. |
| + //(request.status == 200 || request.status == 0)) { |
|
Jacob
2013/01/04 23:55:25
remove this last line.
|
| + onComplete(request); |
| } |
| }); |