Chromium Code Reviews| Index: tools/testing/dart/browser_test.dart |
| diff --git a/tools/testing/dart/browser_test.dart b/tools/testing/dart/browser_test.dart |
| index b47bbf8ed1faefbd0dbe5688cee465c19b686262..0bb930300bf856e0de1f6b441f03dde0f0169a95 100644 |
| --- a/tools/testing/dart/browser_test.dart |
| +++ b/tools/testing/dart/browser_test.dart |
| @@ -54,25 +54,26 @@ library libraryWrapper; |
| part '$test'; |
| """; |
| -String dartTestWrapper(Path dartHome, Path library) { |
| +String dartTestWrapper(Path dartHome, String testPath, Path library) { |
| // Tests inside "pkg" import unittest using "package:". All others use a |
| // relative path. The imports need to agree, so use a matching form here. |
| - var unitTest = dartHome.append("pkg/unittest/lib").toString(); |
| + var testPathDir = pathLib.dirname(testPath.toString()); |
|
Bob Nystrom
2013/01/05 00:26:43
Remove the toString(), it's already one. :)
|
| + var unitTest = pathLib.relative( |
| + dartHome.append("pkg/unittest/lib").toString(), from: testPathDir); |
|
Bob Nystrom
2013/01/05 00:26:43
Mixing Path and the path lib is a bit confusing to
|
| - // TODO(rnystrom): Looking in the entire path here is wrong. It should only |
| - // consider the relative path within dartHome. Unfortunately, |
| - // Path.relativeTo() does not handle cases where library is already a relative |
| - // path, and Path.isAbsolute does not work on Windows. |
| - if (library.segments().contains("pkg")) { |
| + var libString = library.toString(); |
| + if (!pathLib.isAbsolute(libString)) { |
| + libString = pathLib.join(dartHome.toString(), libString); |
|
Bob Nystrom
2013/01/05 00:26:43
toNativeString(), I think? Path always trips me up
|
| + } |
| + if (pathLib.relative(libString, from: dartHome.toString()).contains("pkg")) { |
| unitTest = 'package:unittest'; |
| } |
| - |
| return """ |
| library test; |
| import '$unitTest/unittest.dart' as unittest; |
| import '$unitTest/html_config.dart' as config; |
| -import '${library}' as Test; |
| +import '${pathLib.relative(libString, from: testPathDir)}' as Test; |
| main() { |
| config.useHtmlConfiguration(); |