OLD | NEW |
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file |
2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
4 | 4 |
5 part of html; | 5 part of html; |
6 | 6 |
7 class _HttpRequestUtils { | 7 class _HttpRequestUtils { |
8 | 8 |
9 // Helper for factory HttpRequest.get | 9 // Helper for factory HttpRequest.get |
10 static HttpRequest get(String url, | 10 static HttpRequest get(String url, |
11 onSuccess(HttpRequest request), | 11 onComplete(HttpRequest request), |
12 bool withCredentials) { | 12 bool withCredentials) { |
13 final request = new HttpRequest(); | 13 final request = new HttpRequest(); |
14 request.open('GET', url, true); | 14 request.open('GET', url, true); |
15 | 15 |
16 request.withCredentials = withCredentials; | 16 request.withCredentials = withCredentials; |
17 | 17 |
18 // Status 0 is for local XHR request. | |
19 request.on.readyStateChange.add((e) { | 18 request.on.readyStateChange.add((e) { |
20 if (request.readyState == HttpRequest.DONE && | 19 if (request.readyState == HttpRequest.DONE) { |
21 (request.status == 200 || request.status == 0)) { | 20 // TODO(efortuna): Previously HttpRequest.get only invoked the callback |
22 onSuccess(request); | 21 // when request.status was 0 or 200. This |
| 22 // causes two problems 1) request.status = 0 for ANY local XHR request |
| 23 // (file found or not found) 2) the user facing function claims that the |
| 24 // callback is called on completion of the request, regardless of |
| 25 // status. Because the new event model is coming in soon, rather than |
| 26 // fixing the callbacks version, we just need to revisit the desired |
| 27 // behavior when we're using streams/futures. |
| 28 // Status 0 is for local XHR request. |
| 29 onComplete(request); |
23 } | 30 } |
24 }); | 31 }); |
25 | 32 |
26 request.send(); | 33 request.send(); |
27 | 34 |
28 return request; | 35 return request; |
29 } | 36 } |
30 } | 37 } |
OLD | NEW |