Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1164083003: Free context resources when memory limit is 0 (Closed)

Created:
5 years, 6 months ago by boliu
Modified:
5 years, 6 months ago
Reviewers:
no sievers
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Free context resources when memory limit is 0 Android webview does not use chrome's concept of visibility. Treat memory being set to 0 as signal to drop memory. And drop memory by flipping the surface to invisible and back. BUG=496057 Committed: https://crrev.com/b032a08db9fbaedacaa5b0ac4d39374c4995839c Cr-Commit-Position: refs/heads/master@{#333113}

Patch Set 1 #

Patch Set 2 : compile #

Patch Set 3 : avoid DCHECK #

Patch Set 4 : visible as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M content/browser/android/in_process/synchronous_compositor_output_surface.cc View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
boliu
I think this kinda works.. saves about 16 out of the 20M regression when webview ...
5 years, 6 months ago (2015-06-05 16:14:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164083003/40001
5 years, 6 months ago (2015-06-05 16:38:15 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-05 17:06:51 UTC) #6
no sievers
lgtm
5 years, 6 months ago (2015-06-05 18:21:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164083003/60001
5 years, 6 months ago (2015-06-05 18:24:32 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-05 20:03:24 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:04:19 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b032a08db9fbaedacaa5b0ac4d39374c4995839c
Cr-Commit-Position: refs/heads/master@{#333113}

Powered by Google App Engine
This is Rietveld 408576698