Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.h

Issue 1164073006: Make the logic for stream interception by MimeHandlerViews consistent with starting the plugin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_impl.h
diff --git a/content/browser/loader/resource_dispatcher_host_impl.h b/content/browser/loader/resource_dispatcher_host_impl.h
index 31d94aa422f8014aa6da25c47a3bfbaaf7840f68..177431c8ffff1cebf7c42d4c16f8c164ee6fcce4 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.h
+++ b/content/browser/loader/resource_dispatcher_host_impl.h
@@ -45,6 +45,10 @@
class ResourceHandler;
struct ResourceHostMsg_Request;
+namespace base {
+class FilePath;
+}
+
namespace net {
class URLRequestJobFactory;
}
@@ -233,12 +237,20 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl
scoped_ptr<DownloadSaveInfo> save_info,
const DownloadUrlParameters::OnStartedCallback& started_cb);
- // Must be called after the ResourceRequestInfo has been created
- // and associated with the request. If |payload| is set to a non-empty value,
- // the value will be sent to the old resource handler instead of canceling
+ // Called to determine whether the response to |request| should be intercepted
+ // and handled as a stream. Streams are used to pass direct access to a
+ // resource response to another application (e.g. a web page) without being
+ // handled by the browser itself. If the request should be intercepted as a
+ // stream, a StreamResourceHandler is returned which provides access to the
+ // response.
+ //
+ // This function must be called after the ResourceRequestInfo has been created
+ // and associated with the request. If |payload| is set to a non-empty value,
+ // the value will be sent to the old resource handler instead of canceling
// it, except on HTTP errors. This is marked virtual so it can be overriden in
// testing.
virtual scoped_ptr<ResourceHandler> MaybeInterceptAsStream(
+ const base::FilePath& plugin_path,
mmenke 2015/06/11 19:38:04 Should also document plugin path.
raymes 2015/07/01 05:13:19 Done.
net::URLRequest* request,
ResourceResponse* response,
std::string* payload);

Powered by Google App Engine
This is Rietveld 408576698