Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: content/browser/loader/buffered_resource_handler.h

Issue 1164073006: Make the logic for stream interception by MimeHandlerViews consistent with starting the plugin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/buffered_resource_handler.h
diff --git a/content/browser/loader/buffered_resource_handler.h b/content/browser/loader/buffered_resource_handler.h
index 4e80ec53bd58e9c731037c14fc10ac3af05b7099..f1fae5d0e848fac282e7e8c505e1ff9ecebb9318 100644
--- a/content/browser/loader/buffered_resource_handler.h
+++ b/content/browser/loader/buffered_resource_handler.h
@@ -56,7 +56,13 @@ class CONTENT_EXPORT BufferedResourceHandler
bool ShouldSniffContent();
bool DetermineMimeType();
+ // Returns true if a plugin will handle the current request. |defer| is set
+ // to true if plugin data is stale and needs to be refreshed before the
+ // request can be handled. |request_handled| is false if the request should
+ // be cancelled and true otherwise.
mmenke 2015/06/11 19:38:04 A method called "IsBlah" really should not mean "d
raymes 2015/07/01 05:13:19 Done.
+ bool IsHandledByPlugin(bool* defer, bool* request_handled);
bool SelectNextHandler(bool* defer);
+ // Returns false if the request should be cancelled.
bool UseAlternateNextHandler(scoped_ptr<ResourceHandler> handler,
const std::string& payload_for_old_handler);
@@ -64,7 +70,6 @@ class CONTENT_EXPORT BufferedResourceHandler
void CallReplayReadCompleted();
bool MustDownload();
- bool HasSupportingPlugin(bool* is_stale);
// Copies data from |read_buffer_| to |next_handler_|.
bool CopyReadBufferToNextHandler();

Powered by Google App Engine
This is Rietveld 408576698