Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: content/browser/loader/buffered_resource_handler.h

Issue 1164073006: Make the logic for stream interception by MimeHandlerViews consistent with starting the plugin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/buffered_resource_handler.h
diff --git a/content/browser/loader/buffered_resource_handler.h b/content/browser/loader/buffered_resource_handler.h
index 4e80ec53bd58e9c731037c14fc10ac3af05b7099..e0a1388a7d578fb3ca6123a1ff43fffec2410c70 100644
--- a/content/browser/loader/buffered_resource_handler.h
+++ b/content/browser/loader/buffered_resource_handler.h
@@ -56,6 +56,11 @@ class CONTENT_EXPORT BufferedResourceHandler
bool ShouldSniffContent();
bool DetermineMimeType();
+ // Returns true if a plugin will handle the current request. |defer| is set
+ // to true if plugin data is stale and needs to be refreshed before the
+ // request can be handled. |request_handled| is false if the request should
+ // be cancelled and true otherwise.
mmenke 2015/06/05 18:45:49 Is the request actually cancelled, or handed off t
raymes 2015/06/09 00:10:45 The request is actually cancelled AFAICT
+ bool IsHandledByPlugin(bool* defer, bool* request_handled);
bool SelectNextHandler(bool* defer);
bool UseAlternateNextHandler(scoped_ptr<ResourceHandler> handler,
const std::string& payload_for_old_handler);
mmenke 2015/06/05 18:45:50 Can we document the return value of UseAlternateNe
raymes 2015/06/09 00:10:46 Done.
@@ -64,7 +69,6 @@ class CONTENT_EXPORT BufferedResourceHandler
void CallReplayReadCompleted();
bool MustDownload();
- bool HasSupportingPlugin(bool* is_stale);
// Copies data from |read_buffer_| to |next_handler_|.
bool CopyReadBufferToNextHandler();

Powered by Google App Engine
This is Rietveld 408576698