Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: content/browser/loader/mime_type_resource_handler.h

Issue 1164073006: Make the logic for stream interception by MimeHandlerViews consistent with starting the plugin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/mime_type_resource_handler.h
diff --git a/content/browser/loader/mime_type_resource_handler.h b/content/browser/loader/mime_type_resource_handler.h
index 549d8cf3c9ff292dc963fa929cd6ee62c85ef1eb..272ec186da8f0550f24d149bcc360b284d410c88 100644
--- a/content/browser/loader/mime_type_resource_handler.h
+++ b/content/browser/loader/mime_type_resource_handler.h
@@ -66,6 +66,14 @@ class CONTENT_EXPORT MimeTypeResourceHandler
bool ShouldSniffContent();
bool DetermineMimeType();
+ // Determines whether a plugin will handle the current request. Returns false
mmenke 2015/07/09 20:35:39 Maybe: "Determines whether a plugin will handle t
raymes 2015/07/17 03:21:00 Done.
+ // if there is an error and the request should be cancelled and true
+ // otherwise. |defer| is set to true if plugin data is stale and needs to be
+ // refreshed before the request can be handled (in this case the function
+ // still returns true). If a plugin can handle the request, |request_handled|
+ // is set to true.
mmenke 2015/07/09 20:35:39 Maybe "If a plugin can handle the request, ...." -
raymes 2015/07/17 03:21:00 Done.
+ bool SelectPluginHandler(bool* defer, bool* request_handled);
mmenke 2015/07/09 20:35:39 request_handled -> handled_by_plugin
raymes 2015/07/17 03:21:00 Done.
+ // Returns false if the request should be cancelled.
bool SelectNextHandler(bool* defer);
bool UseAlternateNextHandler(scoped_ptr<ResourceHandler> handler,
const std::string& payload_for_old_handler);
@@ -74,7 +82,6 @@ class CONTENT_EXPORT MimeTypeResourceHandler
void CallReplayReadCompleted();
bool MustDownload();
- bool HasSupportingPlugin(bool* is_stale);
// Copies data from |read_buffer_| to |next_handler_|.
bool CopyReadBufferToNextHandler();

Powered by Google App Engine
This is Rietveld 408576698