Make the logic for stream interception by MimeHandlerViews consistent with starting the plugin

content/browser/loader/resource_dispatcher_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This is the browser side of the resource dispatcher, it receives requests
 // from the child process (i.e. [Renderer, Plugin, Worker]ProcessHost), and
 // dispatches them to URLRequests. It then forwards the messages from the
 // URLRequests back to the correct process for handling.
 //
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
@@ skipping 27 matching lines @@
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/resource_dispatcher_host.h"
 #include "content/public/common/resource_type.h"
 #include "ipc/ipc_message.h"
 #include "net/cookies/canonical_cookie.h"
 #include "net/url_request/url_request.h"
 
 class ResourceHandler;
 struct ResourceHostMsg_Request;
 
+namespace base {
+class FilePath;
+}
+
 namespace net {
 class URLRequestJobFactory;
 }
 
 namespace storage {
 class ShareableFileReference;
 }
 
 namespace content {
 class AppCacheService;
@@ skipping 168 matching lines @@
   // |id| should be |content::DownloadItem::kInvalidId| to request automatic
   // assignment. This is marked virtual so it can be overriden in testing.
   virtual scoped_ptr<ResourceHandler> CreateResourceHandlerForDownload(
       net::URLRequest* request,
       bool is_content_initiated,
       bool must_download,
       uint32 id,
       scoped_ptr<DownloadSaveInfo> save_info,
       const DownloadUrlParameters::OnStartedCallback& started_cb);
 
-  // Must be called after the ResourceRequestInfo has been created
-  // and associated with the request.  If |payload| is set to a non-empty value,
-  // the value will be sent to the old resource handler instead of canceling
-  // it, except on HTTP errors. This is marked virtual so it can be overriden in
-  // testing.
+  // Called to determine whether the response to |request| should be intercepted
+  // and handled as a stream. Streams are used to pass direct access to a
+  // resource response to another application (e.g. a web page) without being
+  // handled by the browser itself. If the request should be intercepted as a
+  // stream, a StreamResourceHandler is returned which provides access to the
+  // response. |plugin_path| is the path to the plugin which is handling the
+  // URL request. This may be empty if there is no plugin handling the request.
+  //
+  // This function must be called after the ResourceRequestInfo has been created
+  // and associated with the request. If |payload| is set to a non-empty value,

[mmenke, 2015/07/09 20:35:39]

This makes it sound like the RDH sends the payload, which is incorrect.

Maybe "If |payload| is set to a non-empty value, the caller must send it to the
old...."

[raymes, 2015/07/17 03:21:00]

Done.

+  // the  value will be sent to the old resource handler instead of canceling

[mmenke, 2015/07/09 20:35:39]

"canceling" -> "canceling it."

[mmenke, 2015/07/09 20:35:39]

"the  value" -> "the value"

[raymes, 2015/07/17 03:21:01]

Done.

[raymes, 2015/07/17 03:21:01]

Done.

   virtual scoped_ptr<ResourceHandler> MaybeInterceptAsStream(
+      const base::FilePath& plugin_path,
       net::URLRequest* request,
       ResourceResponse* response,
       std::string* payload);
 
   ResourceScheduler* scheduler() { return scheduler_.get(); }
 
   // Called by a ResourceHandler when it's ready to start reading data and
   // sending it to the renderer. Returns true if there are enough file
   // descriptors available for the shared memory buffer. If false is returned,
   // the request should cancel.
@@ skipping 326 matching lines @@
   DelegateMap delegate_map_;
 
   scoped_ptr<ResourceScheduler> scheduler_;
 
   DISALLOW_COPY_AND_ASSIGN(ResourceDispatcherHostImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_LOADER_RESOURCE_DISPATCHER_HOST_IMPL_H_