Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2743)

Unified Diff: chrome/browser/permissions/permission_bubble_request_impl.cc

Issue 1164073005: Allow script to request durable storage permission (chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: follow Mounir's suggestions for code cleanup Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_bubble_request_impl.cc
diff --git a/chrome/browser/permissions/permission_bubble_request_impl.cc b/chrome/browser/permissions/permission_bubble_request_impl.cc
index f175962df61dfd2add1ca4c51101bbb17275d8c6..17dcfa5c8970b93c1b230f25588ec58b9d6f4e9c 100644
--- a/chrome/browser/permissions/permission_bubble_request_impl.cc
+++ b/chrome/browser/permissions/permission_bubble_request_impl.cc
@@ -74,6 +74,10 @@ int PermissionBubbleRequestImpl::GetIconID() const {
icon_id = IDR_INFOBAR_PROTECTED_MEDIA_IDENTIFIER;
break;
#endif
+ // TODO(dgrogan): Get a real icon. https://crbug.com/516069
+ case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE:
+ icon_id = IDR_INFOBAR_WARNING;
+ break;
default:
NOTREACHED();
return IDR_INFOBAR_WARNING;
@@ -137,6 +141,9 @@ base::string16 PermissionBubbleRequestImpl::GetMessageTextFragment() const {
message_id = IDS_PROTECTED_MEDIA_IDENTIFIER_PERMISSION_FRAGMENT;
break;
#endif
+ case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE:
+ message_id = IDS_DURABLE_STORAGE_BUBBLE_FRAGMENT;
+ break;
default:
NOTREACHED();
return base::string16();

Powered by Google App Engine
This is Rietveld 408576698