Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: components/content_settings/core/browser/cookie_settings.cc

Issue 1164073005: Allow script to request durable storage permission (chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased onto content setting patch Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/cookie_settings.cc
diff --git a/components/content_settings/core/browser/cookie_settings.cc b/components/content_settings/core/browser/cookie_settings.cc
index 94ffb397dbc038bdb7fe030bc796ca53ac631cdc..3da60b6357e211912032dbb80836a9e9499ad6cb 100644
--- a/components/content_settings/core/browser/cookie_settings.cc
+++ b/components/content_settings/core/browser/cookie_settings.cc
@@ -75,6 +75,7 @@ bool CookieSettings::IsCookieSessionOnly(const GURL& origin) const {
void CookieSettings::GetCookieSettings(
ContentSettingsForOneType* settings) const {
+ // TODO(dgrogan): Why is this returning a value in a void function?
return host_content_settings_map_->GetSettingsForOneType(
CONTENT_SETTINGS_TYPE_COOKIES, std::string(), settings);
}
@@ -113,6 +114,14 @@ void CookieSettings::ResetCookieSetting(
std::string(), CONTENT_SETTING_DEFAULT);
}
+void CookieSettings::GetDurableSettings(
+ ContentSettingsForOneType* settings) const {
+ // TODO(dgrogan): The std::string() is cargo culted and is a
+ // "resource_identifier". The hell is that?
+ host_content_settings_map_->GetSettingsForOneType(
+ CONTENT_SETTINGS_TYPE_DURABLE_STORAGE, std::string(), settings);
+}
+
void CookieSettings::ShutdownOnUIThread() {
DCHECK(thread_checker_.CalledOnValidThread());
pref_change_registrar_.RemoveAll();

Powered by Google App Engine
This is Rietveld 408576698