chrome/browser/content_settings/permission_bubble_request_impl.cc - Issue 1164073005: Allow script to request durable storage permission (chrome side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/permission_bubble_request_impl.cc

Issue 1164073005: Allow script to request durable storage permission (chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased onto content setting patch Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/content_settings/permission_context_uma_util.cc » ('j') | chrome/browser/durable_storage_permission_infobar_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/permission_bubble_request_impl.cc

diff --git a/chrome/browser/content_settings/permission_bubble_request_impl.cc b/chrome/browser/content_settings/permission_bubble_request_impl.cc

index 3fc8bedca41c410a8afc0408c152e50cad27a36b..841a409a5d61db3ded9add1c1fd39c2f25fdeacf 100644

--- a/chrome/browser/content_settings/permission_bubble_request_impl.cc

+++ b/chrome/browser/content_settings/permission_bubble_request_impl.cc

@@ -56,6 +56,10 @@ int PermissionBubbleRequestImpl::GetIconID() const {

icon_id = IDR_INFOBAR_PROTECTED_MEDIA_IDENTIFIER;

break;

#endif

+ // TODO(dgrogan): Get a real icon from rolfe@.

mlamouri (slow - plz ping) 2015/07/02 09:53:01 nit: could you have a bug number?

+ case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE:

+ icon_id = IDR_INFOBAR_WARNING;

+ break;

default:

NOTREACHED();

return IDR_INFOBAR_WARNING;

@@ -119,6 +123,9 @@ base::string16 PermissionBubbleRequestImpl::GetMessageTextFragment() const {

message_id = IDS_PROTECTED_MEDIA_IDENTIFIER_PERMISSION_FRAGMENT;