chrome/browser/durable_storage_permission_context.h - Issue 1164073005: Allow script to request durable storage permission (chrome side)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/durable_storage_permission_context.h

Issue 1164073005: Allow script to request durable storage permission (chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ToT Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/durable_storage_browsertest.cc ('k') | chrome/browser/durable_storage_permission_context.cc » ('j') | chrome/browser/durable_storage_permission_context.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_DURABLE_STORAGE_PERMISSION_CONTEXT_H_

	6 #define CHROME_BROWSER_DURABLE_STORAGE_PERMISSION_CONTEXT_H_

	7

	8 #include "chrome/browser/permissions/permission_context_base.h"

	9

	10 class GURL;

	11 class PermissionRequestID;
	mlamouri (slow - plz ping) 2015/08/05 13:54:55 nit: you don't seem to need these two forward decl nit: you don't seem to need these two forward declare. dgrogan 2015/08/07 20:11:44 Done. Show quoted text On 2015/08/05 13:54:55, Mounir Lamouri wrote: > nit: you don't seem to need these two forward declare. Done.
	12

	13 class DurableStoragePermissionContext : public PermissionContextBase {

	14 public:

	15 explicit DurableStoragePermissionContext(Profile* profile);

	16 ~DurableStoragePermissionContext() override;
	mlamouri (slow - plz ping) 2015/08/05 13:54:55 nit: = default. nit: = default. dgrogan 2015/08/07 20:11:44 Done. Show quoted text On 2015/08/05 13:54:55, Mounir Lamouri wrote: > nit: = default. Done.
	17 bool IsRestrictedToSecureOrigins() const override;
	mlamouri (slow - plz ping) 2015/08/05 13:54:55 nit: add empty line nit: add empty line dgrogan 2015/08/07 20:11:44 Done. Show quoted text On 2015/08/05 13:54:55, Mounir Lamouri wrote: > nit: add empty line Done.
	18

	19 private:

	20
	mlamouri (slow - plz ping) 2015/08/05 13:54:55 nit: remove empty line nit: remove empty line dgrogan 2015/08/07 20:11:44 Done. Show quoted text On 2015/08/05 13:54:55, Mounir Lamouri wrote: > nit: remove empty line Done.
	21 DISALLOW_COPY_AND_ASSIGN(DurableStoragePermissionContext);

	22 };

	23

	24 #endif // CHROME_BROWSER_DURABLE_STORAGE_PERMISSION_CONTEXT_H_

OLD	NEW