Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1164073004: Add mips support to install-debian.wheezy.sysroot.py (Closed)

Created:
5 years, 6 months ago by Sam Clegg
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org, petarj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mips support to install-debian.wheezy.sysroot.py Also, fix remaining issues with sysroot-creator.sh WRT mips. Not sure I missed those the first time. TEST=GYP_DEFINES=target_arch=mipsel gclient runhooks Committed: https://crrev.com/33b96bf8e29a1528360188216474ea4f34eea276 Cr-Commit-Position: refs/heads/master@{#332972}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -10 lines) Patch
M chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py View 5 chunks +19 lines, -6 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/sysroot-creator.sh View 1 5 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sam Clegg
5 years, 6 months ago (2015-06-04 22:18:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164073004/1
5 years, 6 months ago (2015-06-04 22:39:29 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/1164073004/diff/1/chrome/installer/linux/sysroot_scripts/sysroot-creator.sh File chrome/installer/linux/sysroot_scripts/sysroot-creator.sh (right): https://codereview.chromium.org/1164073004/diff/1/chrome/installer/linux/sysroot_scripts/sysroot-creator.sh#newcode325 chrome/installer/linux/sysroot_scripts/sysroot-creator.sh:325: #SubBanner "Rewriting Linker Scripts" Either uncomment or erase.
5 years, 6 months ago (2015-06-04 22:43:45 UTC) #5
Sam Clegg
On 2015/06/04 22:43:45, Lei Zhang wrote: > lgtm > > https://codereview.chromium.org/1164073004/diff/1/chrome/installer/linux/sysroot_scripts/sysroot-creator.sh > File chrome/installer/linux/sysroot_scripts/sysroot-creator.sh (right): ...
5 years, 6 months ago (2015-06-04 22:45:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164073004/20001
5 years, 6 months ago (2015-06-04 22:46:04 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-05 00:07:11 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 00:08:23 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33b96bf8e29a1528360188216474ea4f34eea276
Cr-Commit-Position: refs/heads/master@{#332972}

Powered by Google App Engine
This is Rietveld 408576698