[es6] super.prop, eval and lazy functions

[es6] super.prop, eval and lazy functions

We used to only store the uses_super_property in the preparse data
logger. Let the logger use NeedsHomeObject instead.

BUG=v8:3768
LOG=N
R=wingo, adamk

Committed: https://crrev.com/8c065681865599b29d52c01c6c644fa920c0b551
Cr-Commit-Position: refs/heads/master@{#28806}

[arv (Not doing code reviews), 2015-06-04 19:17:58]

PTAL

[adamk, 2015-06-04 20:02:33]

lgtm % (nit + naming)

https://codereview.chromium.org/1164073003/diff/20001/src/ast.cc
File src/ast.cc (right):

https://codereview.chromium.org/1164073003/diff/20001/src/ast.cc#newcode239
src/ast.cc:239: DCHECK_NOT_NULL(expr->AsFunctionLiteral());
This DCHECK seems a little over-anxious, the above if statement already checked
this.

https://codereview.chromium.org/1164073003/diff/20001/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1164073003/diff/20001/src/parser.cc#newcode4106
src/parser.cc:4106: if (entry.needs_home_object())
scope_->RecordSuperPropertyUsage();
Maybe rename RecordSuperPropertyUsage() to something about HomeObject? I'll
admit "RecordNeedsHomeObject" doesn't sound great, though.

[arv (Not doing code reviews), 2015-06-04 20:15:58]

https://codereview.chromium.org/1164073003/diff/20001/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1164073003/diff/20001/src/parser.cc#newcode4106
src/parser.cc:4106: if (entry.needs_home_object())
scope_->RecordSuperPropertyUsage();
On 2015/06/04 20:02:33, adamk wrote:
> Maybe rename RecordSuperPropertyUsage() to something about HomeObject? I'll
> admit "RecordNeedsHomeObject" doesn't sound great, though.

Yeah. This could be improved.

The Scope keeps track of both super.property and eval but the logging does not
keep 2 flags. So, when we recreate the Scope from the log we lost the calls_eval
flag (it gets set again in the eager parsing)

[arv (Not doing code reviews), 2015-06-04 20:17:45]

https://codereview.chromium.org/1164073003/diff/20001/src/ast.cc
File src/ast.cc (right):

https://codereview.chromium.org/1164073003/diff/20001/src/ast.cc#newcode239
src/ast.cc:239: DCHECK_NOT_NULL(expr->AsFunctionLiteral());
On 2015/06/04 20:02:33, adamk wrote:
> This DCHECK seems a little over-anxious, the above if statement already
checked
> this.

Done.

[arv (Not doing code reviews), 2015-06-04 20:17:45]

Remove a DCHECK

[arv (Not doing code reviews), 2015-06-04 20:46:51]

Make the logger use 2 fields

[arv (Not doing code reviews), 2015-06-04 20:48:26]

https://codereview.chromium.org/1164073003/diff/20001/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1164073003/diff/20001/src/parser.cc#newcode4106
src/parser.cc:4106: if (entry.needs_home_object())
scope_->RecordSuperPropertyUsage();
On 2015/06/04 20:15:57, arv wrote:
> On 2015/06/04 20:02:33, adamk wrote:
> > Maybe rename RecordSuperPropertyUsage() to something about HomeObject? I'll
> > admit "RecordNeedsHomeObject" doesn't sound great, though.
> 
> Yeah. This could be improved.
> 
> The Scope keeps track of both super.property and eval but the logging does not
> keep 2 flags. So, when we recreate the Scope from the log we lost the
calls_eval
> flag (it gets set again in the eager parsing)

I changed it to use 2 fields in the logger instead. It is not required but it is
cleaner and straightforward.

[arv (Not doing code reviews), 2015-06-04 20:49:42]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2015-06-04 20:49:43]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1164073003/#ps60001
(title: "Make the logger use 2 fields")

[commit-bot: I haz the power, 2015-06-04 20:50:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1164073003/60001

[adamk, 2015-06-04 20:50:30]

ah, I like it, still lgtm

[commit-bot: I haz the power, 2015-06-04 21:16:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-04 21:16:46]

Patchset 4 (id:??) landed as
https://crrev.com/8c065681865599b29d52c01c6c644fa920c0b551
Cr-Commit-Position: refs/heads/master@{#28806}