Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 1164063004: Call GetSSLConfig on the IO thread. (Closed)

Created:
5 years, 6 months ago by davidben
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call GetSSLConfig on the IO thread. SSLConfigService::GetSSLConfig is not thread-safe. This should also resolve the test flakiness; the policy change applies on a thread hop, so the value must be queried on a subsequently scheduled hop. Add a DCHECK to SSLConfigServicePref to catch this in future. BUG=496872 Committed: https://crrev.com/c360eb414c97fbcd2cb9025f77cb77e02b2fd7f3 Cr-Commit-Position: refs/heads/master@{#333088}

Patch Set 1 #

Patch Set 2 : DCHECK #

Patch Set 3 : enable the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M chrome/browser/net/ssl_config_service_manager_pref.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 chunks +27 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
davidben
I'm somewhat expecting the try bots to explode from other tests violating the DCHECK, but ...
5 years, 6 months ago (2015-06-04 22:39:41 UTC) #2
agl
LGTM, thanks!
5 years, 6 months ago (2015-06-04 22:53:00 UTC) #3
Mattias Nissler (ping if slow)
LGTM
5 years, 6 months ago (2015-06-05 07:55:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164063004/40001
5 years, 6 months ago (2015-06-05 16:16:44 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-05 17:52:05 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 18:03:41 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c360eb414c97fbcd2cb9025f77cb77e02b2fd7f3
Cr-Commit-Position: refs/heads/master@{#333088}

Powered by Google App Engine
This is Rietveld 408576698