Issue 1164023005: Make Icon work using space-aged base-url technology.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1164023005: Make Icon work using space-aged base-url technology. (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make Icon work using space-aged base-url technology. I also moved Icon back to using int, since double doesn't actually make sense for an icon pixel size. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/93be30a02e9488f502a4495a8f156ad55590b040

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -7 lines)			Patch
M	sky/engine/core/loader/CanvasImageLoader.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/icon.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/icon_button.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/framework/components2/menu_item.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

eseidel

5 years, 6 months ago (2015-06-04 00:16:17 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
93be30a02e9488f502a4495a8f156ad55590b040 (presubmit successful).