Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Side by Side Diff: src/objects.cc

Issue 11640041: Refactoring only: Extracted method to print deopt location. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 9120 matching lines...) Expand 10 before | Expand all | Expand 10 after
9131 CODE_AGE_LIST(HANDLE_CODE_AGE) 9131 CODE_AGE_LIST(HANDLE_CODE_AGE)
9132 #undef HANDLE_CODE_AGE 9132 #undef HANDLE_CODE_AGE
9133 default: 9133 default:
9134 UNREACHABLE(); 9134 UNREACHABLE();
9135 break; 9135 break;
9136 } 9136 }
9137 return NULL; 9137 return NULL;
9138 } 9138 }
9139 9139
9140 9140
9141 void Code::PrintDeoptLocation(int bailout_id) {
9142 const char* last_comment = NULL;
9143 int mask = RelocInfo::ModeMask(RelocInfo::COMMENT)
9144 | RelocInfo::ModeMask(RelocInfo::RUNTIME_ENTRY);
9145 for (RelocIterator it(this, mask); !it.done(); it.next()) {
9146 RelocInfo* info = it.rinfo();
9147 if (info->rmode() == RelocInfo::COMMENT) {
9148 last_comment = reinterpret_cast<const char*>(info->data());
9149 } else if (last_comment != NULL &&
9150 bailout_id == Deoptimizer::GetDeoptimizationId(
9151 info->target_address(), Deoptimizer::EAGER)) {
9152 CHECK(info->rmode() == RelocInfo::RUNTIME_ENTRY);
9153 PrintF(" %s\n", last_comment);
9154 return;
9155 }
9156 }
9157 }
9158
9159
9141 #ifdef ENABLE_DISASSEMBLER 9160 #ifdef ENABLE_DISASSEMBLER
9142 9161
9143 void DeoptimizationInputData::DeoptimizationInputDataPrint(FILE* out) { 9162 void DeoptimizationInputData::DeoptimizationInputDataPrint(FILE* out) {
9144 disasm::NameConverter converter; 9163 disasm::NameConverter converter;
9145 int deopt_count = DeoptCount(); 9164 int deopt_count = DeoptCount();
9146 PrintF(out, "Deoptimization Input Data (deopt points = %d)\n", deopt_count); 9165 PrintF(out, "Deoptimization Input Data (deopt points = %d)\n", deopt_count);
9147 if (0 == deopt_count) return; 9166 if (0 == deopt_count) return;
9148 9167
9149 PrintF(out, "%6s %6s %6s %6s %12s\n", "index", "ast id", "argc", "pc", 9168 PrintF(out, "%6s %6s %6s %6s %12s\n", "index", "ast id", "argc", "pc",
9150 FLAG_print_code_verbose ? "commands" : ""); 9169 FLAG_print_code_verbose ? "commands" : "");
(...skipping 4909 matching lines...) Expand 10 before | Expand all | Expand 10 after
14060 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 14079 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
14061 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 14080 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
14062 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 14081 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
14063 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 14082 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
14064 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 14083 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
14065 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 14084 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
14066 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 14085 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
14067 } 14086 }
14068 14087
14069 } } // namespace v8::internal 14088 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698