Chromium Code Reviews

Issue 1163983002: X87: [es6] Super call in arrows and eval (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Super call in arrows and eval port 4b8051a02ae9f765b7d803fc7986301abde36007 (r28769) original commit message: This splits the SuperReference AST node into SuperPropertyReference and SuperCallReference. The super call reference node consists of three unresolved vars to this, new.target and this_function. These gets declared when the right function is entered and if it is in use. The variables gets assigned in FullCodeGenerator::Generate. This is a revert of the revert 88b1c9170a0293cbcc8bdaf57fbe12744b48d7e8 BUG= Committed: https://crrev.com/689a9ebeddc3200c78495d572302a369fee0ab67 Cr-Commit-Position: refs/heads/master@{#28900}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Stats (+77 lines, -43 lines)
M src/x87/full-codegen-x87.cc View 19 chunks +77 lines, -43 lines 0 comments

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 6 months ago (2015-06-10 09:00:41 UTC) #2
Weiliang
lgtm
5 years, 6 months ago (2015-06-10 09:04:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163983002/20001
5 years, 6 months ago (2015-06-10 09:05:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-10 09:29:06 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 09:29:18 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/689a9ebeddc3200c78495d572302a369fee0ab67
Cr-Commit-Position: refs/heads/master@{#28900}

Powered by Google App Engine