cleanup local reference contributor

cleanup local reference contributor

BUG=
R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/4b082cb871d7b5d87e4fcb5dea98d1e1784efdfc

[danrubel, 2015-06-04 17:53:35]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-06-04 18:09:04]

lgtm

https://codereview.chromium.org/1163973004/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart
(right):

https://codereview.chromium.org/1163973004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart:378:
SimpleIdentifier id = declaration.name;
For consistency with the functions above, inline this.

[danrubel, 2015-06-04 18:17:17]

https://codereview.chromium.org/1163973004/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart
(right):

https://codereview.chromium.org/1163973004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart:378:
SimpleIdentifier id = declaration.name;
On 2015/06/04 18:09:04, Paul Berry wrote:
> For consistency with the functions above, inline this.

Good catch. Done.

[danrubel, 2015-06-04 18:18:06]

Committed patchset #2 (id:20001) manually as
4b082cb871d7b5d87e4fcb5dea98d1e1784efdfc (presubmit successful).