chrome/browser/autocomplete/url_index_private_data.h - Issue 1163963004: [Omnibox] Changing scheme from https:// to http:// results in DCHECK (Always).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/url_index_private_data.h

Issue 1163963004: [Omnibox] Changing scheme from https:// to http:// results in DCHECK (Always). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unit tests. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/in_memory_url_index_unittest.cc ('K') | « chrome/browser/autocomplete/in_memory_url_index_unittest.cc ('k') | chrome/browser/autocomplete/url_index_private_data.cc » ('j') | chrome/browser/autocomplete/url_index_private_data.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/url_index_private_data.h

diff --git a/chrome/browser/autocomplete/url_index_private_data.h b/chrome/browser/autocomplete/url_index_private_data.h

index d13246fb4b636008fe7d7fa5692eb4cc77004d33..f69369444fa08bcf4713d14a58c7301aae47b062 100644

--- a/chrome/browser/autocomplete/url_index_private_data.h

+++ b/chrome/browser/autocomplete/url_index_private_data.h

@@ -149,6 +149,7 @@ class URLIndexPrivateData

friend class AddHistoryMatch;

friend class ::HistoryQuickProviderTest;

friend class InMemoryURLIndexTest;

+ FRIEND_TEST_ALL_PREFIXES(InMemoryURLIndexTest, AddHistoryMatch);

FRIEND_TEST_ALL_PREFIXES(InMemoryURLIndexTest, CacheSaveRestore);

FRIEND_TEST_ALL_PREFIXES(InMemoryURLIndexTest, HugeResultSet);

FRIEND_TEST_ALL_PREFIXES(InMemoryURLIndexTest, ReadVisitsFromHistory);

@@ -207,6 +208,8 @@ class URLIndexPrivateData

ScoredHistoryMatches ScoredMatches() const { return scored_matches_; }

private:

+ friend class InMemoryURLIndexTest;

+ FRIEND_TEST_ALL_PREFIXES(InMemoryURLIndexTest, AddHistoryMatch);

bookmarks::BookmarkModel* bookmark_model_;

const URLIndexPrivateData& private_data_;

const std::string& languages_;