Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 1163963003: [turbofan] Use reference equal to zero instead of a smi check. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use reference equal to zero instead of a smi check. In typed lowering we can use the ReferenceEqual simplified operator instead of ObjectIsSmi to check for context extensions. This generates the desired code. R=mstarzinger@chromium.org Committed: https://crrev.com/e0fa8758584e9aaedebe22fd1ee3c82b3867c14a Cr-Commit-Position: refs/heads/master@{#28776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-03 03:45:02 UTC) #1
Benedikt Meurer
Hey Michi, The ObjectIsSmi hack was actually only necessary if we do it before typed ...
5 years, 6 months ago (2015-06-03 03:46:08 UTC) #2
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-03 05:08:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163963003/1
5 years, 6 months ago (2015-06-03 05:09:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 05:10:51 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 05:11:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0fa8758584e9aaedebe22fd1ee3c82b3867c14a
Cr-Commit-Position: refs/heads/master@{#28776}

Powered by Google App Engine
This is Rietveld 408576698