Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: mojo/runner/context.cc

Issue 1163953002: html_viewer: Add DevToolsAgentImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't create DevToolsAgentImpl instance unless --remote-debugging-port is specified Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/runner/BUILD.gn ('k') | mojo/runner/switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/runner/context.cc
diff --git a/mojo/runner/context.cc b/mojo/runner/context.cc
index b9e85ecb425c6b6d584f41456efe7c5f76e9f81a..57ee11dfc3a36fb07d7373487abd157ebc4603e3 100644
--- a/mojo/runner/context.cc
+++ b/mojo/runner/context.cc
@@ -20,6 +20,7 @@
#include "base/strings/string_util.h"
#include "base/trace_event/trace_event.h"
#include "build/build_config.h"
+#include "components/devtools_service/public/cpp/switches.h"
#include "components/devtools_service/public/interfaces/devtools_service.mojom.h"
#include "mojo/application/public/cpp/application_connection.h"
#include "mojo/application/public/cpp/application_delegate.h"
@@ -174,15 +175,16 @@ void InitNativeOptions(shell::ApplicationManager* manager,
void InitDevToolsServiceIfNeeded(shell::ApplicationManager* manager,
const base::CommandLine& command_line) {
- if (!command_line.HasSwitch(switches::kRemoteDebuggingPort))
+ if (!command_line.HasSwitch(devtools_service::kRemoteDebuggingPort))
return;
std::string port_str =
- command_line.GetSwitchValueASCII(switches::kRemoteDebuggingPort);
+ command_line.GetSwitchValueASCII(devtools_service::kRemoteDebuggingPort);
unsigned port;
if (!base::StringToUint(port_str, &port) || port > 65535) {
- LOG(ERROR) << "Invalid value for switch " << switches::kRemoteDebuggingPort
- << ": '" << port_str << "' is not a valid port number.";
+ LOG(ERROR) << "Invalid value for switch "
+ << devtools_service::kRemoteDebuggingPort << ": '" << port_str
+ << "' is not a valid port number.";
return;
}
« no previous file with comments | « mojo/runner/BUILD.gn ('k') | mojo/runner/switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698