Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1163943005: Subzero: Legalize FP constants directly into memory operands. (Closed)

Created:
5 years, 6 months ago by Jim Stichnoth
Modified:
5 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Legalize FP constants directly into memory operands. Previously, the legalize() function would always force a floating point constant into an xmm register before it could be used in an instruction. This uses an extra register unnecessarily when the instruction allows a memory operand for that operand. We improve this by lowering the FP constant operand to an OperandX8632Mem that wraps a ConstantRelocatable representing the label for the constant pool entry, e.g. [.L$float$0]. (This may end up being copied into an xmm register if the instruction doesn't allow a memory operand for that operand.) BUG= https://code.google.com/p/nativeclient/issues/detail?id=4095 R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=03ffa5853606f11f470baa459ead04dfa1c06ec5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -18 lines) Patch
M src/IceTargetLoweringX8632.cpp View 3 chunks +20 lines, -9 lines 0 comments Download
M tests_lit/llvm2ice_tests/bitcast.ll View 6 chunks +2 lines, -8 lines 0 comments Download
M tests_lit/llvm2ice_tests/undef.ll View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
5 years, 6 months ago (2015-06-04 06:26:41 UTC) #2
jvoung (off chromium)
lgtm
5 years, 6 months ago (2015-06-04 16:18:48 UTC) #3
Jim Stichnoth
5 years, 6 months ago (2015-06-04 16:25:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
03ffa5853606f11f470baa459ead04dfa1c06ec5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698