base/memory/shared_memory_win.cc - Issue 1163943004: Make SharedMemoryHandle a class on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/shared_memory_win.cc

Issue 1163943004: Make SharedMemoryHandle a class on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared_memory_make_class3_base

Patch Set: Fix logic error. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/memory/shared_memory_mac.cc ('K') | « base/memory/shared_memory_unittest.cc ('k') | content/browser/renderer_host/media/video_capture_buffer_pool.cc » ('j') | content/browser/renderer_host/media/video_capture_buffer_pool.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/memory/shared_memory_win.cc

diff --git a/base/memory/shared_memory_win.cc b/base/memory/shared_memory_win.cc

index eacf0d6ccefcd97bd42d6758d4c99597d41f1730..dea50f5d1868f756162aa0d039a113cf045cbafe 100644

--- a/base/memory/shared_memory_win.cc

+++ b/base/memory/shared_memory_win.cc

@@ -46,7 +46,7 @@ SharedMemory::SharedMemory(const std::wstring& name)

name_(name) {

}

-SharedMemory::SharedMemory(SharedMemoryHandle handle, bool read_only)

+SharedMemory::SharedMemory(const SharedMemoryHandle& handle, bool read_only)

: mapped_file_(handle),

memory_(NULL),

read_only_(read_only),

@@ -55,7 +55,8 @@ SharedMemory::SharedMemory(SharedMemoryHandle handle, bool read_only)

lock_(NULL) {

}

-SharedMemory::SharedMemory(SharedMemoryHandle handle, bool read_only,

+SharedMemory::SharedMemory(const SharedMemoryHandle& handle,

+ bool read_only,

ProcessHandle process)

: mapped_file_(NULL),

memory_(NULL),