Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1648)

Unified Diff: base/base.gypi

Issue 1163943004: Make SharedMemoryHandle a class on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared_memory_make_class3_base
Patch Set: Fix logic error. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/memory/BUILD.gn » ('j') | base/memory/shared_memory_handle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gypi
diff --git a/base/base.gypi b/base/base.gypi
index 81a8c99d079ebb648c22d880c5acc68ffe2e3858..10015572f61d34c99ebdac2a86b73d7c6303e5c7 100644
--- a/base/base.gypi
+++ b/base/base.gypi
@@ -358,6 +358,9 @@
'memory/scoped_vector.h',
'memory/shared_memory.h',
'memory/shared_memory_android.cc',
+ 'memory/shared_memory_handle.h',
+ 'memory/shared_memory_handle_mac.cc',
+ 'memory/shared_memory_mac.cc',
'memory/shared_memory_nacl.cc',
'memory/shared_memory_posix.cc',
'memory/shared_memory_win.cc',
@@ -763,6 +766,11 @@
4018,
],
'target_conditions': [
+ ['OS == "mac"', {
+ 'sources!': [
+ 'memory/shared_memory_posix.cc',
Nico 2015/06/17 04:03:20 should probably be renamed to shared_memory_linux.
erikchen 2015/06/17 17:38:55 I thought that Android is considered posix but not
Nico 2015/06/17 17:42:51 Right you are. Nevermind.
+ ],
+ }],
['(<(desktop_linux) == 0 and <(chromeos) == 0) or >(nacl_untrusted_build)==1', {
'sources/': [
['exclude', '^nix/'],
« no previous file with comments | « no previous file | base/memory/BUILD.gn » ('j') | base/memory/shared_memory_handle.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698