Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(149)

Issue 1163943002: Revert of Make Window.prototype.toString return [object Window] at all times. (Closed)

Created:
4 years, 11 months ago by arv (Not doing code reviews)
Modified:
4 years, 11 months ago
Reviewers:
jsbell, adamk
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Make Window.prototype.toString return [object Window] at all times. (patchset #4 id:60001 of https://codereview.chromium.org/1138583002/) Reason for revert: Going to disable --harmony-tostring until our bindings have been updated. Original issue's description: > Make Window.prototype.toString return [object Window] at all times. > > The old code was incorrectly falling back to > Object.prototype.toString.call which does not work as expected without > full support for @@toSringTag > > BUG=239915 > R=adamk, jsbell > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195193 TBR=adamk@chromium.org,jsbell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=239915 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -132 lines) Patch
M LayoutTests/fast/events/event-view-toString-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/http/tests/security/cross-frame-window-to-tostring.html View 1 chunk +0 lines, -86 lines 0 comments Download
D LayoutTests/http/tests/security/cross-frame-window-to-tostring-expected.txt View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/http/tests/security/resources/cross-frame-window-to-string-test.html View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
arv (Not doing code reviews)
Created Revert of Make Window.prototype.toString return [object Window] at all times.
4 years, 11 months ago (2015-06-02 21:54:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163943002/1
4 years, 11 months ago (2015-06-02 21:55:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=196348
4 years, 11 months ago (2015-06-02 21:56:46 UTC) #3
adamk
4 years, 11 months ago (2015-06-02 21:58:47 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698