Issue 1163933002: Remove the concept of an empty RenderNodeWrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1163933002: Remove the concept of an empty RenderNodeWrapper (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove the concept of an empty RenderNodeWrapper This machinery existed only to save one null check. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/162e0d2aa8d27a1d5c8469419bbee8cccbf7e78e

Patch Set 1 #

Total comments: 2

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -112 lines)			Patch
	M	sky/sdk/lib/framework/fn2.dart	View		8 chunks	+13 lines, -112 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hixie

lgtm https://codereview.chromium.org/1163933002/diff/1/sky/sdk/lib/framework/fn2.dart File sky/sdk/lib/framework/fn2.dart (left): https://codereview.chromium.org/1163933002/diff/1/sky/sdk/lib/framework/fn2.dart#oldcode506 sky/sdk/lib/framework/fn2.dart:506: RenderBlock root; put this back

5 years, 6 months ago (2015-06-02 19:44:52 UTC) #2

abarth-chromium

https://codereview.chromium.org/1163933002/diff/1/sky/sdk/lib/framework/fn2.dart File sky/sdk/lib/framework/fn2.dart (left): https://codereview.chromium.org/1163933002/diff/1/sky/sdk/lib/framework/fn2.dart#oldcode506 sky/sdk/lib/framework/fn2.dart:506: RenderBlock root; On 2015/06/02 at 19:44:51, Hixie wrote: > ...

5 years, 6 months ago (2015-06-02 19:45:16 UTC) #3

abarth-chromium

5 years, 6 months ago (2015-06-02 19:45:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
162e0d2aa8d27a1d5c8469419bbee8cccbf7e78e (presubmit successful).

Expand Messages | Collapse Messages