Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1163923006: Sync Document.readyState with the HTML spec (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Sync Document.readyState with the HTML spec https://html.spec.whatwg.org/#the-document-object The only change to the generated code is in the case Document::readyState() returns a null string, but that case is already guarded with an ASSERT_NOT_REACHED() in the implementation. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196622

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/core/dom/Document.idl View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163923006/1
5 years, 6 months ago (2015-06-05 20:08:36 UTC) #2
philipj_slow
PTAL
5 years, 6 months ago (2015-06-05 20:09:08 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-05 21:18:44 UTC) #6
Jens Widell
LGTM
5 years, 6 months ago (2015-06-06 06:24:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163923006/1
5 years, 6 months ago (2015-06-06 06:28:48 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-06 06:33:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196622

Powered by Google App Engine
This is Rietveld 408576698