Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: Source/core/inspector/WorkerDebuggerAgent.cpp

Issue 1163923005: Fix crash in inspector-protocol/debugger/debugger-pause-dedicated-worker.html (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Removed printf Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/WorkerDebuggerAgent.h ('k') | Source/core/inspector/WorkerInspectorController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/WorkerDebuggerAgent.cpp
diff --git a/Source/core/inspector/WorkerDebuggerAgent.cpp b/Source/core/inspector/WorkerDebuggerAgent.cpp
index c09537714a7ee3f17de75248d92a8c85e447657c..6c9dfc4a24ee984c6a7b3c731383f75ecf4fab7e 100644
--- a/Source/core/inspector/WorkerDebuggerAgent.cpp
+++ b/Source/core/inspector/WorkerDebuggerAgent.cpp
@@ -32,35 +32,12 @@
#include "core/inspector/WorkerDebuggerAgent.h"
#include "bindings/core/v8/V8Debugger.h"
+#include "bindings/core/v8/WorkerThreadDebugger.h"
#include "core/inspector/InjectedScript.h"
#include "core/workers/WorkerGlobalScope.h"
-#include "core/workers/WorkerThread.h"
-#include "wtf/MessageQueue.h"
namespace blink {
-namespace {
-
-class RunInspectorCommandsTask final : public V8Debugger::Task {
-public:
- explicit RunInspectorCommandsTask(WorkerThread* thread)
- : m_thread(thread) { }
- virtual ~RunInspectorCommandsTask() { }
- virtual void run() override
- {
- // Process all queued debugger commands. WorkerThread is certainly
- // alive if this task is being executed.
- m_thread->willEnterNestedLoop();
- while (MessageQueueMessageReceived == m_thread->runDebuggerTask(WorkerThread::DontWaitForMessage)) { }
- m_thread->didLeaveNestedLoop();
- }
-
-private:
- WorkerThread* m_thread;
-};
-
-} // namespace
-
PassOwnPtrWillBeRawPtr<WorkerDebuggerAgent> WorkerDebuggerAgent::create(WorkerThreadDebugger* workerThreadDebugger, WorkerGlobalScope* inspectedWorkerGlobalScope, InjectedScriptManager* injectedScriptManager)
{
return adoptPtrWillBeNoop(new WorkerDebuggerAgent(workerThreadDebugger, inspectedWorkerGlobalScope, injectedScriptManager));
@@ -83,11 +60,6 @@ DEFINE_TRACE(WorkerDebuggerAgent)
InspectorDebuggerAgent::trace(visitor);
}
-void WorkerDebuggerAgent::interruptAndDispatchInspectorCommands()
-{
- debugger().interruptAndRun(adoptPtr(new RunInspectorCommandsTask(m_inspectedWorkerGlobalScope->thread())));
-}
-
void WorkerDebuggerAgent::startListeningV8Debugger()
{
m_workerThreadDebugger->addListener(this);
« no previous file with comments | « Source/core/inspector/WorkerDebuggerAgent.h ('k') | Source/core/inspector/WorkerInspectorController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698