Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 1163923005: Fix crash in inspector-protocol/debugger/debugger-pause-dedicated-worker.html (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/inspector/InspectorTaskRunner.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Google Inc. All rights reserved. 3 * Copyright (C) 2013 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 if (enabled()) 233 if (enabled())
234 return; 234 return;
235 235
236 enable(); 236 enable();
237 237
238 ASSERT(frontend()); 238 ASSERT(frontend());
239 } 239 }
240 240
241 void InspectorDebuggerAgent::disable(ErrorString*) 241 void InspectorDebuggerAgent::disable(ErrorString*)
242 { 242 {
243 fprintf(stderr, "InspectorDebuggerAgent::disable %p>>\n", this);
sergeyv 2015/06/03 14:07:49 lets be silent
yurys 2015/06/03 14:29:12 Done.
243 if (!enabled()) 244 if (!enabled())
244 return; 245 return;
245 246
246 disable(); 247 disable();
247 m_state->setBoolean(DebuggerAgentState::debuggerEnabled, false); 248 m_state->setBoolean(DebuggerAgentState::debuggerEnabled, false);
249 fprintf(stderr, "InspectorDebuggerAgent::disable %p<<\n", this);
248 } 250 }
249 251
250 static PassOwnPtr<ScriptRegexp> compileSkipCallFramePattern(String patternText) 252 static PassOwnPtr<ScriptRegexp> compileSkipCallFramePattern(String patternText)
251 { 253 {
252 if (patternText.isEmpty()) 254 if (patternText.isEmpty())
253 return nullptr; 255 return nullptr;
254 OwnPtr<ScriptRegexp> result = adoptPtr(new ScriptRegexp(patternText, TextCas eSensitive)); 256 OwnPtr<ScriptRegexp> result = adoptPtr(new ScriptRegexp(patternText, TextCas eSensitive));
255 if (!result->isValid()) 257 if (!result->isValid())
256 result.clear(); 258 result.clear();
257 return result.release(); 259 return result.release();
(...skipping 1455 matching lines...) Expand 10 before | Expand all | Expand 10 after
1713 RefPtr<ExceptionDetails> exceptionDetails = ExceptionDetails::create().setTe xt(toCoreStringWithUndefinedOrNullCheck(message->Get())); 1715 RefPtr<ExceptionDetails> exceptionDetails = ExceptionDetails::create().setTe xt(toCoreStringWithUndefinedOrNullCheck(message->Get()));
1714 exceptionDetails->setLine(message->GetLineNumber()); 1716 exceptionDetails->setLine(message->GetLineNumber());
1715 exceptionDetails->setColumn(message->GetStartColumn()); 1717 exceptionDetails->setColumn(message->GetStartColumn());
1716 v8::Local<v8::StackTrace> messageStackTrace = message->GetStackTrace(); 1718 v8::Local<v8::StackTrace> messageStackTrace = message->GetStackTrace();
1717 if (!messageStackTrace.IsEmpty() && messageStackTrace->GetFrameCount() > 0) 1719 if (!messageStackTrace.IsEmpty() && messageStackTrace->GetFrameCount() > 0)
1718 exceptionDetails->setStackTrace(createScriptCallStack(isolate, messageSt ackTrace, messageStackTrace->GetFrameCount())->buildInspectorArray()); 1720 exceptionDetails->setStackTrace(createScriptCallStack(isolate, messageSt ackTrace, messageStackTrace->GetFrameCount())->buildInspectorArray());
1719 return exceptionDetails.release(); 1721 return exceptionDetails.release();
1720 } 1722 }
1721 1723
1722 } // namespace blink 1724 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/inspector/InspectorTaskRunner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698