Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: chrome/browser/ui/views/ash/balloon_view_ash.cc

Issue 11639041: Added support for image notifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/ash/balloon_view_ash.cc
diff --git a/chrome/browser/ui/views/ash/balloon_view_ash.cc b/chrome/browser/ui/views/ash/balloon_view_ash.cc
index 674d45caa1e8170dc2c829b983025bc8dd6782c0..9cc1bb33f97afacb9a1f928fddfbe86dbd4ebf3b 100644
--- a/chrome/browser/ui/views/ash/balloon_view_ash.cc
+++ b/chrome/browser/ui/views/ash/balloon_view_ash.cc
@@ -188,6 +188,11 @@ void BalloonViewAsh::SetNotificationIcon(const std::string& id,
GetMessageCenter()->SetNotificationPrimaryIcon(id, image);
}
+void BalloonViewAsh::SetNotificationImage(const std::string& id,
+ const gfx::ImageSkia& image) {
+ GetMessageCenter()->SetNotificationImage(id, image);
+}
+
void BalloonViewAsh::DownloadImages(const Notification& notification) {
// Cancel any previous downloads.
downloads_.clear();
@@ -202,6 +207,19 @@ void BalloonViewAsh::DownloadImages(const Notification& notification) {
base::Unretained(this)));
}
+ // Set up a download for the notification's image if appropriate.
+ const base::DictionaryValue* optional_fields = notification.optional_fields();
+ if (optional_fields->HasKey(ui::notifications::kImageUrlKey)) {
+ string16 url;
+ optional_fields->GetString(ui::notifications::kImageUrlKey, &url);
+ if (!url.empty()) {
+ GetImageDownload(GURL(url)).AddCallback(
+ message_center::kNotificationPreferredImageSize, base::Bind(
+ &BalloonViewAsh::SetNotificationImage,
+ base::Unretained(this)));
+ }
+ }
+
// Start the downloads.
for (ImageDownloads::const_iterator i = downloads_.begin();
i != downloads_.end();

Powered by Google App Engine
This is Rietveld 408576698